spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhengruifeng <...@git.apache.org>
Subject [GitHub] spark issue #16171: [SPARK-18739][ML][PYSPARK] Models in pyspark.classificat...
Date Wed, 07 Dec 2016 01:33:23 GMT
Github user zhengruifeng commented on the issue:

    https://github.com/apache/spark/pull/16171
  
    @srowen No, I think this maybe the third of five PR. Distinct from the first two PRs which
only deal with the overlook, the PR modify the hierarchy of classification `Model`s in the
python side. With regard to clustering and features, I suggest that we first change the hierarchy
in the scala side: add some abstract classes like `ClusteringModel`, `ProbabilisticClusteringModel`,
`FeatureModel`. And then modify pyspark to keep it in line with it. Otherwise we need to manually
add setXXXCol methods one by one, like what we do now. I think the modifications in clustering
and features are big enough to derserve a single JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message