spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request #16168: [SPARK-18209][SQL] More robust view canonicalizat...
Date Tue, 06 Dec 2016 13:47:08 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16168#discussion_r91078407
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala
---
    @@ -114,9 +117,26 @@ private[hive] class HiveMetastoreCatalog(sparkSession: SparkSession)
extends Log
           alias.map(a => SubqueryAlias(a, qualifiedTable, None)).getOrElse(qualifiedTable)
         } else if (table.tableType == CatalogTableType.VIEW) {
           val viewText = table.viewText.getOrElse(sys.error("Invalid view without text."))
    +      val unresolvedPlan = sparkSession.sessionState.sqlParser.parsePlan(viewText).transform
{
    --- End diff --
    
    This will probably break with common table expressions. We could just set the current
database, have the analyzer solve it, and set the current database back to its old value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message