spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #16137: [SPARK-18708][CORE] Improvement/improve docs in s...
Date Tue, 06 Dec 2016 04:05:13 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16137#discussion_r91008621
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -119,22 +119,22 @@ class SparkContext(config: SparkConf) extends Logging {
       /**
        * Alternative constructor that allows setting common Spark properties directly
        *
    -   * @param master Cluster URL to connect to (e.g. mesos://host:port, spark://host:port,
local[4]).
    -   * @param appName A name for your application, to display on the cluster web UI
    -   * @param conf a [[org.apache.spark.SparkConf]] object specifying other Spark parameters
    +   * @param master cluster URL to connect to (e.g. mesos://host:port, spark://host:port,
local[4]).
    +   * @param appName a name for your application, to display on the cluster web UI
    +   * @param conf a `org.apache.spark.SparkConf` object specifying other Spark parameters
        */
       def this(master: String, appName: String, conf: SparkConf) =
         this(SparkContext.updatedConf(conf, master, appName))
     
       /**
        * Alternative constructor that allows setting common Spark properties directly
        *
    -   * @param master Cluster URL to connect to (e.g. mesos://host:port, spark://host:port,
local[4]).
    -   * @param appName A name for your application, to display on the cluster web UI.
    -   * @param sparkHome Location where Spark is installed on cluster nodes.
    -   * @param jars Collection of JARs to send to the cluster. These can be paths on the
local file
    +   * @param master cluster URL to connect to (e.g. mesos://host:port, spark://host:port,
local[4]).
    +   * @param appName a name for your application, to display on the cluster web UI.
    +   * @param sparkHome location where Spark is installed on cluster nodes.
    +   * @param jars collection of JARs to send to the cluster. These can be paths on the
local file
        *             system or HDFS, HTTP, HTTPS, or FTP URLs.
    -   * @param environment Environment variables to set on worker nodes.
    +   * @param environment environment variables to set on worker nodes.
    --- End diff --
    
    Do we have a rule (or other references) to make them lower-cased? I am worried of similar
changes in the future and it might be great if we have a concrete reason here to change so.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message