spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #16137: [SPARK-18708][CORE] Improvement/improve docs in s...
Date Tue, 06 Dec 2016 04:02:46 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16137#discussion_r91008467
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -923,15 +971,13 @@ class SparkContext(config: SparkConf) extends Logging {
       /**
        * Load data from a flat binary file, assuming the length of each record is constant.
        *
    -   * @note We ensure that the byte array for each record in the resulting RDD
    +   * @note we ensure that the byte array for each record in the resulting RDD
    --- End diff --
    
    I am not sure of making this lower-cased because we will see this as the start of sentence

    - scaladoc
      ![2016-12-06 1 02 12](https://cloud.githubusercontent.com/assets/6477701/20912647/38ccf9e4-bbb4-11e6-8346-42cd6297d075.png)
    
    - javadoc
      ![2016-12-06 1 02 05](https://cloud.githubusercontent.com/assets/6477701/20912648/38d2160e-bbb4-11e6-8d72-1c4480ca2276.png)
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message