spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #16160: [SPARK-18721][SS]Fix ForeachSink with watermark +...
Date Mon, 05 Dec 2016 23:22:15 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16160#discussion_r90979548
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ForeachSink.scala
---
    @@ -32,46 +31,26 @@ import org.apache.spark.sql.catalyst.plans.logical.CatalystSerde
     class ForeachSink[T : Encoder](writer: ForeachWriter[T]) extends Sink with Serializable
{
     
       override def addBatch(batchId: Long, data: DataFrame): Unit = {
    -    // TODO: Refine this method when SPARK-16264 is resolved; see comments below.
    --- End diff --
    
    `SPARK-16264` was resolved as `Won't Fix`. So I removed it from the comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message