spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark issue #15998: [SPARK-18572][SQL] Add a method `listPartitionNames` to ...
Date Fri, 02 Dec 2016 06:33:55 GMT
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/15998
  
    What is the expected output? In the ExternalCatalogSuite, it sounds like we do not issue
any error. 
    ```
    catalog.listPartitionNames("db2", "tbl2", Some(Map("unknown" -> "unknown")))
    ```
    
    In the `SessionCatalogSuite`, we also should add the test cases like [`listPartitions`](https://github.com/apache/spark/blob/e64a2047eaf02d65dcf98b6e0710e10196aa74b1/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala#L872-L889)
and also the negative cases like what I mentioned above. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message