spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shea-parkes <...@git.apache.org>
Subject [GitHub] spark issue #16094: [SPARK-18541][Python]Add metadata parameter to pyspark.s...
Date Fri, 02 Dec 2016 00:30:31 GMT
Github user shea-parkes commented on the issue:

    https://github.com/apache/spark/pull/16094
  
    Gah, I'm sorry.  I forgot python 2.6 compatibility.  I'll switch this over shortly to
use the old-school style.  Likely do something like this:
    
    ```python
    def alias(self, *alias, **kwargs):
        metadata = kwargs.pop('metadata', None)
        assert not kwargs
    ```
    
    I'll also add some unit tests and raise a more proper exception (if I can find one).
    
    Sorry again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message