spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steveloughran <...@git.apache.org>
Subject [GitHub] spark pull request #16089: [SPARK-18658][SQL] Write text records directly to...
Date Thu, 01 Dec 2016 18:04:59 GMT
Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16089#discussion_r90502669
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
    @@ -194,4 +194,8 @@ private[sql] class JacksonGenerator(
           writeFields(row, schema, rootFieldWriters)
         }
       }
    +
    +  def writeLineEnding(): Unit = {
    +    gen.writeRaw('\n')
    --- End diff --
    
    Presumably just a convoluted way to create a byte array containing the byte `0x0a` then


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message