Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9809D200BC9 for ; Sat, 26 Nov 2016 14:25:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8BDDF160B14; Sat, 26 Nov 2016 13:25:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CC7BF160B00 for ; Sat, 26 Nov 2016 14:25:41 +0100 (CET) Received: (qmail 63595 invoked by uid 500); 26 Nov 2016 13:25:40 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 63571 invoked by uid 99); 26 Nov 2016 13:25:40 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Nov 2016 13:25:40 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3A075E0163; Sat, 26 Nov 2016 13:25:40 +0000 (UTC) From: holdenk To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #15817: [SPARK-18366][PYSPARK][ML] Add handleInvalid to Pyspark ... Content-Type: text/plain Message-Id: <20161126132540.3A075E0163@git1-us-west.apache.org> Date: Sat, 26 Nov 2016 13:25:40 +0000 (UTC) archived-at: Sat, 26 Nov 2016 13:25:42 -0000 Github user holdenk commented on the issue: https://github.com/apache/spark/pull/15817 Thanks for working on this @techaddict - one super minor point , but could you also maybe update the PR description to mention the testing is done with new doctests? This is really minor but for people skimming the changelog the PR description will end up as the commit message. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org