Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: rxin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-15833-spark@git.apache.org>
In-Reply-To: <git-pr-15833-spark@git.apache.org>
Subject: [GitHub] spark pull request #15833: [SPARK-18353][CORE] spark.rpc.askTimeout defalut ...
Content-Type: text/plain
Message-Id: <20161109180417.68124E188C@git1-us-west.apache.org>
Date: Wed,  9 Nov 2016 18:04:17 +0000 (UTC)
archived-at: Wed, 09 Nov 2016 18:04:19 -0000

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15833#discussion_r87245015
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/Client.scala ---
    @@ -221,7 +221,6 @@ object Client {
         val conf = new SparkConf()
         val driverArgs = new ClientArguments(args)
     
    -    conf.set("spark.rpc.askTimeout", "10")
    --- End diff --
    
    I guess part of the reason is that master/client have low memory usage and as a result unlikely to have long timeouts due to gc.
    
    @srowen I'm not sure if this is a good change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org