Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: ericl <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-15705-spark@git.apache.org>
In-Reply-To: <git-pr-15705-spark@git.apache.org>
Subject: [GitHub] spark pull request #15705: [SPARK-18183] [SPARK-18184] Fix INSERT [INTO|OVER...
Content-Type: text/plain
Message-Id: <20161101183059.50AB3E1772@git1-us-west.apache.org>
Date: Tue,  1 Nov 2016 18:30:59 +0000 (UTC)
archived-at: Tue, 01 Nov 2016 18:31:01 -0000

Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15705#discussion_r85993725
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala ---
    @@ -173,12 +175,22 @@ case class DataSourceAnalysis(conf: CatalystConf) extends Rule[LogicalPlan] {
             case LogicalRelation(r: HadoopFsRelation, _, _) => r.location.rootPaths
           }.flatten
     
    -      val mode = if (overwrite) SaveMode.Overwrite else SaveMode.Append
    -      if (overwrite && inputPaths.contains(outputPath)) {
    +      val mode = if (overwrite.enabled) SaveMode.Overwrite else SaveMode.Append
    +      if (overwrite.enabled && inputPaths.contains(outputPath)) {
             throw new AnalysisException(
               "Cannot overwrite a path that is also being read from.")
           }
     
    +      val overwritePartitionPath = if (overwrite.specificPartition.isDefined &&
    --- End diff --
    
    Yeah, that seems a little cleaner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org