spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kayousterhout <...@git.apache.org>
Subject [GitHub] spark issue #15505: [SPARK-17931][CORE] taskScheduler has some unneeded seri...
Date Tue, 29 Nov 2016 18:57:55 GMT
Github user kayousterhout commented on the issue:

    https://github.com/apache/spark/pull/15505
  
    @witgo I don't mind moving the serialization out of resourceOffer, but I do think it's
helpful to separate that from the too-many-objects-serialized issue.  Smaller PRs are easier
for folks to code review (and as a result, are easier to merge) and it also makes it clearer
where any performance improvements are coming from (i.e., are the performance improvements
from eliminating the serialization, or just from moving it to a separate thread? It sounds
like perhaps the latter).  I'd propose first merging #16053 (I'll clean this up to include
the Mesos changes) and then merging this PR (so this PR will have only the change to split
the resourceOffer and serialization process).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message