spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request #15877: [SPARK-18429] [SQL] implement a new Aggregate for...
Date Tue, 29 Nov 2016 06:07:46 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15877#discussion_r89946344
  
    --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketchImpl.java
---
    @@ -152,6 +153,16 @@ public void add(Object item) {
       public void add(Object item, long count) {
         if (item instanceof String) {
           addString((String) item, count);
    +    } else if (item instanceof BigDecimal) {
    +      addString(((BigDecimal) item).toString(), count);
    --- End diff --
    
    Is this true? 
    
    "1.0" and "1.00" is the same value but not the same string representation.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message