spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #15981: [SPARK-18547][core] Propagate I/O encryption key ...
Date Mon, 28 Nov 2016 22:57:28 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15981#discussion_r89903336
  
    --- Diff: mesos/src/main/scala/org/apache/spark/executor/MesosExecutorBackend.scala ---
    @@ -75,7 +75,7 @@ private[spark] class MesosExecutorBackend
         val conf = new SparkConf(loadDefaults = true).setAll(properties)
         val port = conf.getInt("spark.executor.port", 0)
         val env = SparkEnv.createExecutorEnv(
    -      conf, executorId, slaveInfo.getHostname, port, cpusPerTask, isLocal = false)
    +      conf, executorId, slaveInfo.getHostname, port, cpusPerTask, None, isLocal = false)
    --- End diff --
    
    This means mesos is not suppported. Right? Could you throw an exception if IO encryption
is enabled for mesos?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message