spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mallman <...@git.apache.org>
Subject [GitHub] spark pull request #15998: [SPARK-18572][SQL] Add a method `listPartitionNam...
Date Mon, 28 Nov 2016 17:53:25 GMT
Github user mallman commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15998#discussion_r89839435
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
    @@ -730,6 +730,23 @@ class SessionCatalog(
       }
     
       /**
    +   * List the names of all partitions that belong to the specified table, assuming it
exists.
    +   *
    +   * A partial partition spec may optionally be provided to filter the partitions returned.
    +   * For instance, if there exist partitions (a='1', b='2'), (a='1', b='3') and (a='2',
b='4'),
    +   * then a partial spec of (a='1') will return the first two only.
    +   */
    +  def listPartitionNames(
    +      tableName: TableIdentifier,
    +      partialSpec: Option[TablePartitionSpec] = None): Seq[String] = {
    +    val db = formatDatabaseName(tableName.database.getOrElse(getCurrentDatabase))
    +    val table = formatTableName(tableName.table)
    +    requireDbExists(db)
    +    requireTableExists(TableIdentifier(table, Option(db)))
    --- End diff --
    
    I don't know. The only method that calls that method is `dropPartitions`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message