spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #16013: [SPARK-3359][DOCS] Make javadoc8 working for unid...
Date Mon, 28 Nov 2016 09:22:36 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16013#discussion_r89741513
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/BoostingStrategy.scala
---
    @@ -36,14 +36,14 @@ import org.apache.spark.mllib.tree.loss.{LogLoss, Loss, SquaredError}
      * @param validationTol validationTol is a condition which decides iteration termination
when
      *                      runWithValidation is used.
      *                      The end of iteration is decided based on below logic:
    - *                      If the current loss on the validation set is > 0.01, the diff
    + *                      If the current loss on the validation set is greater than 0.01,
the diff
      *                      of validation error is compared to relative tolerance which is
      *                      validationTol * (current loss on the validation set).
    - *                      If the current loss on the validation set is <= 0.01, the
diff
    - *                      of validation error is compared to absolute tolerance which is
    + *                      If the current loss on the validation set is less than or euqal
to 0.01,
    --- End diff --
    
    typo: euqal -> equal


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message