spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #16013: [SPARK-3359][DOCS] Make javadoc8 working for unid...
Date Sun, 27 Nov 2016 14:53:52 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16013#discussion_r89691656
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala ---
    @@ -152,10 +152,12 @@ class DoubleRDDFunctions(self: RDD[Double]) extends Logging with
Serializable {
     
       /**
        * Compute a histogram using the provided buckets. The buckets are all open
    -   * to the right except for the last which is closed
    +   * to the right except for the last which is closed.
    +   * {{{
        *  e.g. for the array
        *  [1, 10, 20, 50] the buckets are [1, 10) [10, 20) [20, 50]
        *  e.g 1<=x<10 , 10<=x<20, 20<=x<=50
    +   * }}}
    --- End diff --
    
    Yeap. I tested some cases with it (If I remember correctly) and it seems any `{@foo }`
syntax is treated as back-tick-quoted by scaladoc (I will test more in case and will be back
here to fix the comment if I was wrong). Sure, sounds great!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message