spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From witgo <...@git.apache.org>
Subject [GitHub] spark pull request #15505: [SPARK-17931][CORE] taskScheduler has some unneed...
Date Wed, 23 Nov 2016 01:49:20 GMT
Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15505#discussion_r89246343
  
    --- Diff: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
---
    @@ -139,29 +139,6 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext
with B
         assert(!failedTaskSet)
       }
     
    -  test("Scheduler does not crash when tasks are not serializable") {
    --- End diff --
    
    Yes. 
    For rdd and closures, there are already related test cases, see [DAGSchedulerSuite.scala#L506](https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala#L506)
    For task, user can use a custom partition, and the partition instance may not be serializable.
This has no test cases I will add one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message