spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #15965: [SPARK-18356] [ML] Improve MLKmeans Performance
Date Tue, 22 Nov 2016 11:06:54 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15965#discussion_r89091350
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala ---
    @@ -306,12 +307,18 @@ class KMeans @Since("1.5.0") (
     
       @Since("2.0.0")
       override def fit(dataset: Dataset[_]): KMeansModel = {
    +    val handlePersistence = dataset.rdd.getStorageLevel == StorageLevel.NONE
    +    fit(dataset, handlePersistence)
    +  }
    +  protected def fit(dataset: Dataset[_], handlePersistence: Boolean): KMeansModel = {
    --- End diff --
    
    Still wrong -- no space, and now no `@Since` at all. This is `@Since("2.2.0")` if it goes
in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message