spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tejasapatil <...@git.apache.org>
Subject [GitHub] spark pull request #15959: [SPARK-18522][SQL] Explicit contract for column s...
Date Tue, 22 Nov 2016 04:12:12 GMT
Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15959#discussion_r89034659
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
    @@ -100,99 +100,30 @@ object AnalyzeColumnCommand extends Logging {
           exprOption.getOrElse(throw new AnalysisException(s"Invalid column name: $col."))
         }).toSeq
     
    +    // Make sure the column types are supported for stats gathering.
    +    attributesToAnalyze.foreach { attr =>
    +      if (!ColumnStat.supportsType(attr.dataType)) {
    +        throw new AnalysisException(
    +          s"Data type ${attr.dataType.simpleString} for column ${attr.name} is not supported
" +
    --- End diff --
    
    nit : please include the table name in the message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message