spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request #15499: [SPARK-17955][SQL] Make DataFrameReader.jdbc call...
Date Mon, 21 Nov 2016 23:28:58 GMT
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15499#discussion_r89013219
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
    @@ -232,10 +232,10 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends
Logging {
           parts: Array[Partition],
           connectionProperties: Properties): DataFrame = {
         // connectionProperties should override settings in extraOptions.
    -    val params = extraOptions.toMap ++ connectionProperties.asScala.toMap
    -    val options = new JDBCOptions(url, table, params)
    -    val relation = JDBCRelation(parts, options)(sparkSession)
    --- End diff --
    
    I see. I am sorry it seems a careless mistake.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message