spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request #15923: [SPARK-4105] retry the fetch or stage if shuffle ...
Date Sat, 19 Nov 2016 01:22:46 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15923#discussion_r88767018
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
    @@ -56,8 +59,10 @@ final class ShuffleBlockFetcherIterator(
         shuffleClient: ShuffleClient,
    --- End diff --
    
    Could you update the Scaladoc to document the two new parameters here? I understand what
`streamWrapper` means from context but it might be useful for new readers of this code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message