spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...
Date Fri, 18 Nov 2016 09:16:55 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15907#discussion_r88621534
  
    --- Diff: core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala
---
    @@ -30,7 +32,7 @@ import org.apache.spark.util.collection.Sorter
     import org.apache.spark.util.random.XORShiftRandom
     
     class RadixSortSuite extends SparkFunSuite with Logging {
    -  private val N = 10000  // scale this down for more readable results
    +  private val N = 10000.toLong  // scale this down for more readable results
    --- End diff --
    
    Write `10000L`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message