spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...
Date Fri, 18 Nov 2016 03:28:01 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15780#discussion_r88594560
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
    @@ -603,7 +603,14 @@ case class ExternalMapToCatalyst private(
     
       override def foldable: Boolean = false
     
    -  override def dataType: MapType = MapType(keyConverter.dataType, valueConverter.dataType)
    +  override def dataType: MapType = {
    +    val isPrimitiveType = valueType match {
    +      case BooleanType | ByteType | ShortType | IntegerType | LongType |
    +            FloatType | DoubleType => true
    +      case _ => false
    +    }
    +    MapType(keyConverter.dataType, valueConverter.dataType, !isPrimitiveType)
    --- End diff --
    
    Yes, it returns `true` now. I think that this is because `LambdaVariable.nullable` always
return `true`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message