spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kiszk <...@git.apache.org>
Subject [GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...
Date Thu, 17 Nov 2016 13:44:48 GMT
Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13909#discussion_r88453551
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
    @@ -56,29 +56,49 @@ case class CreateArray(children: Seq[Expression]) extends Expression
{
       }
     
       override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
    +    val unsafeArrayClass = classOf[UnsafeArrayData].getName
         val arrayClass = classOf[GenericArrayData].getName
         val values = ctx.freshName("values")
         ctx.addMutableState("Object[]", values, s"this.$values = null;")
     
    -    ev.copy(code = s"""
    -      final boolean ${ev.isNull} = false;
    -      this.$values = new Object[${children.size}];""" +
    -      ctx.splitExpressions(
    -        ctx.INPUT_ROW,
    -        children.zipWithIndex.map { case (e, i) =>
    -          val eval = e.genCode(ctx)
    -          eval.code + s"""
    +    val ArrayType(dt, _) = dataType
    +    val evals = children.map(e => e.genCode(ctx))
    +    val isPrimitiveArray = ctx.isPrimitiveType(dt) && evals.forall(_.isNull ==
"false")
    --- End diff --
    
    i see. done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message