spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ponkin <>
Subject [GitHub] spark pull request #15917: SPARK-18252: Using RoaringBitmap for bloom filter...
Date Thu, 17 Nov 2016 12:20:09 GMT
Github user ponkin commented on a diff in the pull request:
    --- Diff: common/sketch/src/main/java/org/apache/spark/util/sketch/
    @@ -0,0 +1,136 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.util.sketch;
    +import org.roaringbitmap.RoaringBitmap;
    +import java.util.Arrays;
    +class RoaringBitmapArray {
    --- End diff --
    well, the main point of this improvement is to save memory - now even filters with few
elements acquire space needed for full bloom filter. With this improvement bloom filter size
will increase as we insert values in it. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message