spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...
Date Wed, 16 Nov 2016 23:44:29 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15852#discussion_r88353713
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala ---
    @@ -161,7 +161,8 @@ trait StreamTest extends QueryTest with SharedSQLContext with Timeouts
{
       /** Starts the stream, resuming if data has already been processed. It must not be
running. */
       case class StartStream(
           trigger: Trigger = ProcessingTime(0),
    -      triggerClock: Clock = new SystemClock)
    +      triggerClock: Clock = new SystemClock,
    +      pairs: mutable.Map[String, String] = mutable.Map.empty)
    --- End diff --
    
    nit: it's better to rename `pairs` to `additionalConfs` for readability.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message