spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request #15703: [SPARK-18186] Migrate HiveUDAFFunction to TypedIm...
Date Wed, 16 Nov 2016 19:17:53 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15703#discussion_r88310092
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/hiveUDFs.scala ---
    @@ -263,8 +265,19 @@ private[hive] case class HiveGenericUDTF(
     }
     
     /**
    - * Currently we don't support partial aggregation for queries using Hive UDAF, which
may hurt
    - * performance a lot.
    + * While being evaluated by Spark SQL, the aggregation state of a Hive UDAF may be in
the following
    + * three formats:
    + *
    + *  1. a Spark SQL value, or
    + *  2. an instance of some concrete `GenericUDAFEvaluator.AggregationBuffer` class, or
    + *  3. a Java object that can be inspected using the `ObjectInspector` returned by the
    + *     `GenericUDAFEvaluator.init()` method.
    --- End diff --
    
    Thanks, added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message