spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sethah <...@git.apache.org>
Subject [GitHub] spark pull request #15874: [Spark-18408] API Improvements for LSH
Date Tue, 15 Nov 2016 01:06:35 GMT
Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15874#discussion_r87876322
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/MinHashLSH.scala ---
    @@ -102,8 +103,7 @@ class MinHashModel private[ml] (
      */
     @Experimental
     @Since("2.1.0")
    -class MinHash(override val uid: String) extends LSH[MinHashModel] with HasSeed {
    -
    +class MinHashLSH(override val uid: String) extends LSH[MinHashModel] with HasSeed {
    --- End diff --
    
    change the model names to reflect the new estimator names.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message