spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] spark pull request #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION sho...
Date Mon, 14 Nov 2016 22:45:31 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15704#discussion_r87910722
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -418,27 +419,58 @@ case class AlterTableRenamePartitionCommand(
      */
     case class AlterTableDropPartitionCommand(
         tableName: TableIdentifier,
    -    specs: Seq[TablePartitionSpec],
    +    specs: Seq[Expression],
         ifExists: Boolean,
         purge: Boolean)
    -  extends RunnableCommand {
    +  extends RunnableCommand with PredicateHelper {
    +
    +  private def isRangeComparison(expr: Expression): Boolean = {
    +    expr.find(e => e.isInstanceOf[BinaryComparison] && !e.isInstanceOf[EqualTo]).isDefined
    +  }
     
       override def run(sparkSession: SparkSession): Seq[Row] = {
         val catalog = sparkSession.sessionState.catalog
         val table = catalog.getTableMetadata(tableName)
    +    val resolver = sparkSession.sessionState.conf.resolver
         DDLUtils.verifyAlterTableType(catalog, table, isView = false)
         DDLUtils.verifyPartitionProviderIsHive(sparkSession, table, "ALTER TABLE DROP PARTITION")
     
    -    val normalizedSpecs = specs.map { spec =>
    -      PartitioningUtils.normalizePartitionSpec(
    -        spec,
    -        table.partitionColumnNames,
    -        table.identifier.quotedString,
    -        sparkSession.sessionState.conf.resolver)
    +    specs.foreach { expr =>
    +      expr.references.foreach { attr =>
    +        if (!table.partitionColumnNames.exists(resolver(_, attr.name))) {
    +          throw new AnalysisException(s"${attr.name} is not a valid partition column
" +
    +            s"in table ${table.identifier.quotedString}.")
    +        }
    +      }
         }
     
    -    catalog.dropPartitions(
    -      table.identifier, normalizedSpecs, ignoreIfNotExists = ifExists, purge = purge)
    +    if (specs.exists(isRangeComparison)) {
    +      val partitionSet = scala.collection.mutable.Set.empty[CatalogTablePartition]
    +      specs.foreach { spec =>
    +        val partitions = catalog.listPartitionsByFilter(table.identifier, Seq(spec))
    +        if (partitions.nonEmpty) {
    +          partitionSet ++= partitions
    +        } else if (!ifExists) {
    +          throw new AnalysisException(s"There is no partition for ${spec.sql}")
    +        }
    +      }
    +      catalog.dropPartitions(table.identifier, partitionSet.map(_.spec).toSeq,
    +        ignoreIfNotExists = ifExists, purge = purge)
    +    } else {
    +      val normalizedSpecs = specs.map { expr =>
    +        val spec = splitConjunctivePredicates(expr).map {
    +          case BinaryComparison(left, right) =>
    --- End diff --
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message