spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request #15868: [SPARK-18413][SQL] Control the number of JDBC con...
Date Mon, 14 Nov 2016 22:42:48 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15868#discussion_r87910285
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
---
    @@ -667,7 +667,14 @@ object JdbcUtils extends Logging {
         val getConnection: () => Connection = createConnectionFactory(options)
         val batchSize = options.batchSize
         val isolationLevel = options.isolationLevel
    -    df.foreachPartition(iterator => savePartition(
    +    val numPartitions = options.numPartitions
    +    val repartitionedDF =
    +      if (numPartitions != null && numPartitions.toInt != df.rdd.getNumPartitions)
{
    --- End diff --
    
    Normally, based on my understanding, users only cares the maximal number of connections.
Thus, no need to repartition it when `numPartitions.toInt >= df.rdd.getNumPartitions`,
right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message