spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request #15790: [SPARK-18264][SPARKR] build vignettes with packag...
Date Thu, 10 Nov 2016 22:31:47 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15790#discussion_r87500577
  
    --- Diff: R/check-cran.sh ---
    @@ -36,11 +36,27 @@ if [ ! -z "$R_HOME" ]
     fi
     echo "USING R_HOME = $R_HOME"
     
    -# Build the latest docs
    -$FWDIR/create-docs.sh
    +# Build the latest docs, but not vignettes, which is built with the package next
    +NO_VIGNETTES=1 $FWDIR/create-docs.sh
     
    -# Build a zip file containing the source package
    -"$R_SCRIPT_PATH/"R CMD build $FWDIR/pkg
    +# Build source package with vignettes
    +SPARK_HOME="$(cd "`dirname "$0"`"/..; pwd)"
    --- End diff --
    
    that's odd, it works in my environment.
    do you happen to have check-cran.sh under a subdirectory of R?
    
    this is the code:
    ```
    SPARK_HOME="$(cd "`dirname "$0"`"/..; pwd)"
    . "${SPARK_HOME}"/bin/load-spark-env.sh
    ```
    
    so for /opt/spark/R/check-cran.sh, it should look for /opt/spark/bin/load-spark-env.sh
    and SPARK_HOME should be /opt/spark


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message