spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <>
Subject [GitHub] spark pull request #15830: [SPARK-18375][SPARK-18383][BUILD][CORE]Upgrade ne...
Date Thu, 10 Nov 2016 10:21:44 GMT
Github user srowen commented on a diff in the pull request:
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2222,6 +2223,9 @@ private[spark] object Utils extends Logging {
           case e: MultiException =>
    +      case e: NativeIoException =>
    +        e.getMessage().startsWith("bind() failed: ") ||
    --- End diff --
    OK. It wouldn't hurt to be defensive rather than depend on this IMHO. If it changes then
suddenly this becomes a mysterious NPE.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message