spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thunterdb <...@git.apache.org>
Subject [GitHub] spark issue #15074: [SPARK-17520] Implement a better __eq__ for SparseMatrix
Date Tue, 08 Nov 2016 22:43:44 GMT
Github user thunterdb commented on the issue:

    https://github.com/apache/spark/pull/15074
  
    @dbtsai and @holdenk have a good point about the equality being a actually an equivalence
check (we want to check that two matrices have the same content, not that two python objects
have the same structure and content).
    I suggest instead to add a fast path when comparing 2 sparse matrices with the same transpose
parameter, and send all the rest to the existing, slower `.toArray()` method. As @holdenk
pointed out, the path for different transposes could be accelerated as well, but I am not
sure how important it is in practice since this PR is already a performance-related PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message