spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From thunterdb <...@git.apache.org>
Subject [GitHub] spark pull request #12819: [SPARK-14077][ML] Refactor NaiveBayes to support ...
Date Tue, 08 Nov 2016 16:21:18 GMT
Github user thunterdb commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12819#discussion_r87025073
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/NaiveBayes.scala ---
    @@ -109,10 +118,89 @@ class NaiveBayes @Since("1.5.0") (
             s" numClasses=$numClasses, but thresholds has length ${$(thresholds).length}")
         }
     
    -    val oldDataset: RDD[OldLabeledPoint] =
    -      extractLabeledPoints(dataset).map(OldLabeledPoint.fromML)
    -    val oldModel = OldNaiveBayes.train(oldDataset, $(smoothing), $(modelType))
    -    NaiveBayesModel.fromOld(oldModel, this)
    +    val numFeatures = dataset.select(col($(featuresCol))).head().getAs[Vector](0).size
    +
    +    val requireNonnegativeValues: Vector => Unit = (v: Vector) => {
    --- End diff --
    
    @zhengruifeng (minor) this method is static and does not depend on the state of the object.
It is preferable to put it in the companion object. Also, because people do not have a functional
programing background, it is better to define it with `def` rather than a `val`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message