spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request #15769: [SPARK-18191][CORE] Port RDD API to use commit pr...
Date Sat, 05 Nov 2016 20:12:08 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15769#discussion_r86672448
  
    --- Diff: core/src/main/scala/org/apache/spark/internal/io/SparkNewHadoopWriter.scala
---
    @@ -0,0 +1,248 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.internal.io
    +
    +import java.text.SimpleDateFormat
    +import java.util.{Date, Locale}
    +
    +import scala.reflect.ClassTag
    +import scala.util.DynamicVariable
    +
    +import org.apache.hadoop.conf.Configuration
    +import org.apache.hadoop.fs.Path
    +import org.apache.hadoop.mapred.{JobConf, JobID}
    +import org.apache.hadoop.mapreduce._
    +import org.apache.hadoop.mapreduce.task.TaskAttemptContextImpl
    +
    +import org.apache.spark.{SparkConf, SparkContext, SparkException, TaskContext}
    +import org.apache.spark.deploy.SparkHadoopUtil
    +import org.apache.spark.executor.OutputMetrics
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.util.{SerializableConfiguration, Utils}
    +
    +/**
    + * A helper object that saves an RDD using a Hadoop OutputFormat
    + * (from the newer mapreduce API, not the old mapred API).
    + */
    +private[spark]
    +object SparkNewHadoopWriter extends Logging {
    +
    +  /** A shared job description for all the write tasks. */
    +  private class WriteJobDescription[K, V](
    +      val jobTrackerId: String,
    +      val serializableHadoopConf: SerializableConfiguration,
    +      val outputFormat: Class[_ <: OutputFormat[K, V]])
    +    extends Serializable {
    +  }
    +
    +  /**
    +   * Basic work flow of this command is:
    +   * 1. Driver side setup, including output committer initialization and data source
specific
    +   *    preparation work for the write job to be issued.
    +   * 2. Issues a write job consists of one or more executor side tasks, each of which
writes all
    +   *    rows within an RDD partition.
    +   * 3. If no exception is thrown in a task, commits that task, otherwise aborts that
task;  If any
    +   *    exception is thrown during task commitment, also aborts that task.
    +   * 4. If all tasks are committed, commit the job, otherwise aborts the job;  If any
exception is
    +   *    thrown during job commitment, also aborts the job.
    +   */
    +  def write[K, V: ClassTag](
    +      sparkContext: SparkContext,
    +      rdd: RDD[(K, V)],
    +      committer: HadoopMapReduceCommitProtocol,
    --- End diff --
    
    i'd move the creation of the commit protocol here here. The reason I put it outside in
SQL was because streaming and batch needed to specify different protocols, but that problem
doesn't exist in core.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message