spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hayashidac <...@git.apache.org>
Subject [GitHub] spark pull request #15652: [SPARK-16987] [None] Add spark-default.conf prope...
Date Thu, 03 Nov 2016 11:37:16 GMT
Github user hayashidac commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15652#discussion_r86325009
  
    --- Diff: docs/configuration.md ---
    @@ -1664,6 +1664,14 @@ Apart from these, the following properties are also available,
and may be useful
             </td>
         </tr>
         <tr>
    +        <td><code>spark.ssl.<particular protocol>.port</code></td>
    --- End diff --
    
    It has a reason for this.
    If an user set spark.ssl.port, the port of history server, SparkUI, MasterWebUI, and WorkerWebUI
will collapse as I mentioned at the beginning of this PR.
    It is because WebUI.scala is inheried by HistoryServer.scala, SparkUI, MasterWebUI, and
WorkerWebUI.
    How do you think about it?
    
    
    > I created a pull request, but there is a problem.
    > Port should be separated for each particular process such as history server and spark

    > ui.
    > But user can configure spark.ssl.port with this code and when configure it, each

    > process will try to create connections with same port and it doesn't work good.
    > Because of structure of existing function, it has impact to other functions to solve
the
    > problem.
    > So there are three answer about it.
    >
    > Use this fix code so user can configure a specific secure port, but spark.ssl.port
doesn't > work good.
    > Don't change and close issue.
    > We should be able to configure a specific secure port completely, so drastically
change > many functions.
    > Please comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message