spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark issue #15704: [SPARK-17732][SQL] ALTER TABLE DROP PARTITION should sup...
Date Thu, 03 Nov 2016 08:05:12 GMT
Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/15704
  
    When the partition specs have `equal to` only, our implementation first checks all before
starting the actual drop. See the [codes](https://github.com/apache/spark/blob/ccb11543048dccd4cc590a8db1df1d9d5847d112/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala#L454-L489).

    
    In addition, when we hit any failure after starting to drop the partitions, we log the
following error message:
    ```Scala
    logError(
      s"""
         |======================
         |Attempt to drop the partition specs in table '$table' database '$db':
         |${specs.mkString("\n")}
         |In this attempt, the following partitions have been dropped successfully:
         |${droppedParts.mkString("\n")}
         |The remaining partitions have not been dropped:
         |${remainingParts.mkString("\n")}
         |======================
       """.stripMargin)
    ```
    
    I think we should make the behaviors of DROP PARTITION consistent, no matter whether there
exists any non-equal-to comparator. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message