Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-15539-spark@git.apache.org>
In-Reply-To: <git-pr-15539-spark@git.apache.org>
Subject: [GitHub] spark pull request #15539: [SPARK-17994] [SQL] Add back a file status cache ...
Content-Type: text/plain
Message-Id: <20161021021248.78B50DFBA8@git1-us-west.apache.org>
Date: Fri, 21 Oct 2016 02:12:48 +0000 (UTC)
archived-at: Fri, 21 Oct 2016 02:12:50 -0000

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15539#discussion_r84409377
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ListingFileCatalog.scala ---
    @@ -64,11 +66,18 @@ class ListingFileCatalog(
       }
     
       override def refresh(): Unit = {
    +    refresh0(true)
    --- End diff --
    
    nit: instead of having a parameter in `refresh0`, can we just call `refresh0` here, and then invalidate the file status cache?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org