Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: tejasapatil <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-13775-spark@git.apache.org>
In-Reply-To: <git-pr-13775-spark@git.apache.org>
Subject: [GitHub] spark pull request #13775: [SPARK-16060][SQL] Vectorized Orc reader
Content-Type: text/plain
Message-Id: <20161018005542.A316CE17B1@git1-us-west.apache.org>
Date: Tue, 18 Oct 2016 00:55:42 +0000 (UTC)
archived-at: Tue, 18 Oct 2016 00:55:45 -0000

Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13775#discussion_r83752360
  
    --- Diff: sql/hive/src/main/java/org/apache/hadoop/hive/ql/io/orc/SparkVectorizedOrcRecordReader.java ---
    @@ -0,0 +1,189 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.hadoop.hive.ql.io.orc;
    +
    +import java.io.IOException;
    +import java.util.LinkedList;
    +import java.util.List;
    +
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hive.ql.exec.vector.ColumnVector;
    +import org.apache.hadoop.hive.ql.exec.vector.BytesColumnVector;
    +import org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector;
    +import org.apache.hadoop.hive.ql.exec.vector.DoubleColumnVector;
    +import org.apache.hadoop.hive.ql.exec.vector.LongColumnVector;
    +import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
    +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector;
    +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspectorFactory;
    +import org.apache.hadoop.hive.serde2.objectinspector.PrimitiveObjectInspector;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructField;
    +import org.apache.hadoop.hive.serde2.objectinspector.StructObjectInspector;
    +import org.apache.hadoop.hive.serde2.typeinfo.DecimalTypeInfo;
    +import org.apache.hadoop.hive.serde2.typeinfo.PrimitiveTypeInfo;
    +import org.apache.hadoop.io.NullWritable;
    +import org.apache.hadoop.mapred.FileSplit;
    +import org.apache.hadoop.mapred.RecordReader;
    +
    +/**
    + * A mapred.RecordReader that returns VectorizedRowBatch.
    + */
    +public class SparkVectorizedOrcRecordReader
    +      implements RecordReader<NullWritable, VectorizedRowBatch> {
    +    private final org.apache.hadoop.hive.ql.io.orc.RecordReader reader;
    +    private final long offset;
    +    private final long length;
    +    private float progress = 0.0f;
    +    private ObjectInspector objectInspector;
    +
    +    SparkVectorizedOrcRecordReader(Reader file, Configuration conf,
    +        FileSplit fileSplit) throws IOException {
    +      this.offset = fileSplit.getStart();
    +      this.length = fileSplit.getLength();
    +      this.objectInspector = file.getObjectInspector();
    +      this.reader = OrcInputFormat.createReaderFromFile(file, conf, this.offset,
    +        this.length);
    +      this.progress = reader.getProgress();
    +    }
    +
    +    /**
    +     * Create a ColumnVector based on given ObjectInspector's type info.
    +     *
    +     * @param inspector ObjectInspector
    +     */
    +    private ColumnVector createColumnVector(ObjectInspector inspector) {
    +      switch(inspector.getCategory()) {
    +        case PRIMITIVE:
    +          {
    +            PrimitiveTypeInfo primitiveTypeInfo =
    +              (PrimitiveTypeInfo) ((PrimitiveObjectInspector)inspector).getTypeInfo();
    +            switch(primitiveTypeInfo.getPrimitiveCategory()) {
    +              case BOOLEAN:
    +              case BYTE:
    +              case SHORT:
    +              case INT:
    +              case LONG:
    +              case DATE:
    +              case INTERVAL_YEAR_MONTH:
    +                return new LongColumnVector(VectorizedRowBatch.DEFAULT_SIZE);
    +              case FLOAT:
    +              case DOUBLE:
    +                return new DoubleColumnVector(VectorizedRowBatch.DEFAULT_SIZE);
    +              case BINARY:
    +              case STRING:
    +              case CHAR:
    +              case VARCHAR:
    +                BytesColumnVector column = new BytesColumnVector(VectorizedRowBatch.DEFAULT_SIZE);
    +                column.initBuffer();
    +                return column;
    +              case DECIMAL:
    +                DecimalTypeInfo tInfo = (DecimalTypeInfo) primitiveTypeInfo;
    +                return new DecimalColumnVector(VectorizedRowBatch.DEFAULT_SIZE,
    +                    tInfo.precision(), tInfo.scale());
    +              default:
    +                throw new RuntimeException("Vectorizaton is not supported for datatype:"
    +                    + primitiveTypeInfo.getPrimitiveCategory());
    +            }
    +          }
    +        default:
    +          throw new RuntimeException("Vectorization is not supported for datatype:"
    +              + inspector.getCategory());
    +      }
    +    }
    +
    +    /**
    +     * Walk through the object inspector and add column vectors
    +     *
    +     * @param oi StructObjectInspector
    +     * @param cvList ColumnVectors are populated in this list
    +     */
    +    private void allocateColumnVector(StructObjectInspector oi,
    +        List<ColumnVector> cvList) {
    +      if (cvList == null) {
    +        throw new RuntimeException("Null columnvector list");
    +      }
    +      if (oi == null) {
    +        return;
    +      }
    +      final List<? extends StructField> fields = oi.getAllStructFieldRefs();
    +      for(StructField field : fields) {
    --- End diff --
    
    nit: space after `for`. There are other places in this PR where the same comment will apply


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org