Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 63642200BAA for ; Thu, 13 Oct 2016 06:10:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 61D86160AEE; Thu, 13 Oct 2016 04:10:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9E358160ACA for ; Thu, 13 Oct 2016 06:10:26 +0200 (CEST) Received: (qmail 31391 invoked by uid 500); 13 Oct 2016 04:10:25 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 31293 invoked by uid 99); 13 Oct 2016 04:10:23 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Oct 2016 04:10:23 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9C4BFE0381; Thu, 13 Oct 2016 04:10:23 +0000 (UTC) From: HyukjinKwon To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #15432: [SPARK-17854][SQL] rand/randn allows null/long as input ... Content-Type: text/plain Message-Id: <20161013041023.9C4BFE0381@git1-us-west.apache.org> Date: Thu, 13 Oct 2016 04:10:23 +0000 (UTC) archived-at: Thu, 13 Oct 2016 04:10:27 -0000 Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15432 Strictly, the JIRA describes handling `null` and we might not have to generalize the cases further. > it will failed when do select rand(null) Also, I would like to add the edge cases here but I'd like to avoid PR is being hold. As not all the things have a standard to follow, we can define the behaviour here. I don't have access to Oracle and DB2. Do you think Hive, PostgreSQL and MySQL examples are not enough? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org