Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B0BA8200B9E for ; Sat, 8 Oct 2016 14:44:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AF390160ADF; Sat, 8 Oct 2016 12:44:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E9E21160AD1 for ; Sat, 8 Oct 2016 14:44:39 +0200 (CEST) Received: (qmail 99773 invoked by uid 500); 8 Oct 2016 12:44:39 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 99744 invoked by uid 99); 8 Oct 2016 12:44:37 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Oct 2016 12:44:37 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6D7B3DFE65; Sat, 8 Oct 2016 12:44:37 +0000 (UTC) From: Stibbons To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark issue #14963: [SPARK-16992][PYSPARK] Virtualenv for Pylint and pep8 in... Content-Type: text/plain Message-Id: <20161008124437.6D7B3DFE65@git1-us-west.apache.org> Date: Sat, 8 Oct 2016 12:44:37 +0000 (UTC) archived-at: Sat, 08 Oct 2016 12:44:40 -0000 Github user Stibbons commented on the issue: https://github.com/apache/spark/pull/14963 sorry I wrote on the wrong pull request, I was talking about the virtualenv support for executor (#14180) :( This one is indeed only to reenable pylint. Merging this would allow me to submit new patch with minor code style corrections, and get rid of this weird manual pep8 package download. virtualenv and pip have been made to make life of python developers easy, make deployment reproductible and cheap to maintain, I just would like to instill this to the Spark project. There are many reason why playing with the PYTHONPATH is wrong. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org