spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaceklaskowski <...@git.apache.org>
Subject [GitHub] spark pull request #15603: [WEBUI][MINOR] Return types in methods + cleanup
Date Sun, 23 Oct 2016 19:52:02 GMT
GitHub user jaceklaskowski opened a pull request:

    https://github.com/apache/spark/pull/15603

    [WEBUI][MINOR] Return types in methods + cleanup

    ## What changes were proposed in this pull request?
    
    The main purpose of the change is to discuss the purpose of `SparkUITab` class and `appUIAddress`
attribute since they seem to introduce nothing new. Once agreed they're not needed I'm going
to remove the comment.
    
    Code cleanup
    
    ## How was this patch tested?
    
    Local build


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaceklaskowski/spark sparkui-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15603
    
----
commit 6fcd247f546c2cfe15f6909bf8a9d75dc822ef15
Author: Jacek Laskowski <jacek@japila.pl>
Date:   2016-10-23T19:45:21Z

    [WEBUI][MINOR] Return types in methods + cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message