spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request #15465: [SPARK-17909][SQL] we should create table before ...
Date Thu, 13 Oct 2016 15:02:30 GMT
GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/15465

    [SPARK-17909][SQL] we should create table before writing out the data in CTAS

    ## What changes were proposed in this pull request?
    
    In `CreateDataSourceTableAsSelectCommand`, we write out the data to the table location
before create table, because we assume the data schema may change after it has been written
out. However, we may only change the schema's nullability. We can still create table first,
with regarding all columns are nullable.
    
    ## How was this patch tested?
    
    existing tests.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark nullable

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15465
    
----
commit 543f0143e65b561eb79f7c4f8783fa85d28fe2a1
Author: Wenchen Fan <wenchen@databricks.com>
Date:   2016-10-13T14:57:26Z

    we should create table before writing out the data in CTAS

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message