spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ajbozarth <...@git.apache.org>
Subject [GitHub] spark pull request #15366: [SPARK-17793] [Web UI] Sorting on the description...
Date Wed, 05 Oct 2016 23:44:10 GMT
GitHub user ajbozarth opened a pull request:

    https://github.com/apache/spark/pull/15366

    [SPARK-17793] [Web UI] Sorting on the description on the Job or Stage page doesn’t always
work

    ## What changes were proposed in this pull request?
    
    Added secondary sorting on stage name for the description column. This provide a clearer
behavior in the common case where the Description column only comprises of Stage names instead
of the option description value.
    
    ## How was this patch tested?
    
    manual testing and dev/run-tests
    
    Screenshots of sorting on both description and stage name as well as an example of both:
    ![screen shot 2016-10-04 at 1 09 39 pm](https://cloud.githubusercontent.com/assets/13952758/19135523/067b042e-8b1a-11e6-912e-e6371d006d21.png)
    ![screen shot 2016-10-04 at 1 09 51 pm](https://cloud.githubusercontent.com/assets/13952758/19135526/06960936-8b1a-11e6-85e9-8aaf694c5f7b.png)
    ![screen shot 2016-10-05 at 1 14 45 pm](https://cloud.githubusercontent.com/assets/13952758/19135525/069547da-8b1a-11e6-8692-6524c75c4c07.png)
    ![screen shot 2016-10-05 at 1 14 51 pm](https://cloud.githubusercontent.com/assets/13952758/19135524/0694b4d2-8b1a-11e6-92dc-c8aa514e4f62.png)
    ![screen shot 2016-10-05 at 4 42 52 pm](https://cloud.githubusercontent.com/assets/13952758/19135618/e232eafe-8b1a-11e6-88b3-ff0bbb26b7f8.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajbozarth/spark spark17793

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15366.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15366
    
----
commit 6420d1d19113916b746ff2bc45e0665f97104156
Author: Alex Bozarth <ajbozart@us.ibm.com>
Date:   2016-10-05T23:32:45Z

    Added secondary sorting on stage name for the description column

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message