spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request #15626: SPARK-17829 [SQL] Stable format for offset log
Date Fri, 28 Oct 2016 20:12:42 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15626#discussion_r85602088
  
    --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSourceOffsetSuite.scala
---
    @@ -36,4 +37,9 @@ class KafkaSourceOffsetSuite extends OffsetSuite {
       compare(
         one = KafkaSourceOffset(("t", 0, 1L)),
         two = KafkaSourceOffset(("t", 0, 2L), ("t", 1, 1L)))
    +
    +  compare(
    --- End diff --
    
    I would make this a separate `test("json serialization") { ... }` just to verify whether
json ser --> deser gives back the same results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message