spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tdas <...@git.apache.org>
Subject [GitHub] spark pull request #15626: SPARK-17829 [SQL] Stable format for offset log
Date Tue, 25 Oct 2016 19:45:33 GMT
Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15626#discussion_r84980489
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Offset.scala
---
    @@ -23,4 +23,16 @@ package org.apache.spark.sql.execution.streaming
      * ordering of two [[Offset]] instances.  We do assume that if two offsets are `equal`
then no
      * new data has arrived.
      */
    -trait Offset extends Serializable {}
    +abstract class Offset {
    +  def json: String
    +}
    +
    +/** Used when loading */
    --- End diff --
    
    Improve the docs to something like "A JSON-serialized representation of an Offset that
is used for saving offsets to the offset log"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message