spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hqzizania <...@git.apache.org>
Subject [GitHub] spark pull request #13891: [SPARK-6685][MLLIB]Use DSYRK to compute AtA in AL...
Date Tue, 25 Oct 2016 16:52:40 GMT
Github user hqzizania commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13891#discussion_r84948911
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -864,6 +864,9 @@ object MimaExcludes {
           // [SPARK-12221] Add CPU time to metrics
           ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.status.api.v1.TaskMetrics.this"),
           ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.status.api.v1.TaskMetricDistributions.this")
    +    ) ++ Seq(
    +      // SPARK-6685
    +      ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.ml.recommendation.ALS.train")
    --- End diff --
    
    Actually, I don't know how to write the "mima exclude" exactly. It could be not a proper
solution to the failure of mima, which may be caused by the modification to [def train](https://github.com/apache/spark/pull/13891/files#diff-be65dd1d6adc53138156641b610fcadaR724)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message