spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request #15009: [SPARK-17443][SPARK-11035] Stop Spark Application...
Date Mon, 24 Oct 2016 21:52:17 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r84785866
  
    --- Diff: core/src/main/scala/org/apache/spark/launcher/LauncherBackend.scala ---
    @@ -17,38 +17,71 @@
     
     package org.apache.spark.launcher
     
    +import java.io.IOException
     import java.net.{InetAddress, Socket}
     
     import org.apache.spark.SPARK_VERSION
    +import org.apache.spark.internal.Logging
     import org.apache.spark.launcher.LauncherProtocol._
    -import org.apache.spark.util.{ThreadUtils, Utils}
    +import org.apache.spark.util.{ShutdownHookManager, ThreadUtils, Utils}
     
     /**
      * A class that can be used to talk to a launcher server. Users should extend this class
to
      * provide implementation for the abstract methods.
      *
      * See `LauncherServer` for an explanation of how launcher communication works.
      */
    -private[spark] abstract class LauncherBackend {
    +private[spark] abstract class LauncherBackend extends Logging {
     
       private var clientThread: Thread = _
       private var connection: BackendConnection = _
       private var lastState: SparkAppHandle.State = _
    +  private var stopFlag: Boolean = false
    --- End diff --
    
    nit: type is not necessary. Also, not a big fan of the name of this variable, it should
be more descriptive. Like `stopOnShutdown`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message