spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sameeragarwal <...@git.apache.org>
Subject [GitHub] spark pull request #15319: [SPARK-17733][SQL] InferFiltersFromConstraints ru...
Date Mon, 24 Oct 2016 09:32:38 GMT
Github user sameeragarwal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15319#discussion_r84646230
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
    @@ -74,20 +74,98 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends
TreeNode[PlanT
        * additional constraint of the form `b = 5`
        */
       private def inferAdditionalConstraints(constraints: Set[Expression]): Set[Expression]
= {
    +    // Collect alias from expressions to avoid producing non-converging set of constraints
    +    // for recursive functions.
    +    //
    +    // Don't apply transform on constraints if the replacement will cause an recursive
deduction,
    +    // when that happens a non-converging set of constraints will be created and finally
throw
    +    // OOM Exception.
    +    // For more details, refer to https://issues.apache.org/jira/browse/SPARK-17733
    +    val aliasMap = AttributeMap((expressions ++ children.flatMap(_.expressions)).collect
{
    +      case a: Alias => (a.toAttribute, a.child)
    +    })
    +
    +    val equalExprSets = generateEqualExpressionSets(constraints, aliasMap)
    --- End diff --
    
    nit: How about calling them `val constraintClasses`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message